logical: skip outbound fk constraint dependencies on deletes#169781
Open
DarrylWong wants to merge 1 commit intocockroachdb:masterfrom
Open
logical: skip outbound fk constraint dependencies on deletes#169781DarrylWong wants to merge 1 commit intocockroachdb:masterfrom
DarrylWong wants to merge 1 commit intocockroachdb:masterfrom
Conversation
This change fixes a bug where occasionally created a dependency that an FK being deleted is dependent on the PK it is referencing being deleted first. This happens if the FK is the table's own PK, as PK's are always emitted for deletes. This caused us to mistakenly consume the event as an update instead of a delete. Instead, we gate on the decoded row's IsDelete. Fixes: cockroachdb#169778
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
DarrylWong
requested review from
KeithCh and
jeffswenson
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where occasionally created a dependency that an FK being deleted is dependent on the PK it is referencing being deleted first. This happens if the FK is the table's own PK, as PK's are always emitted for deletes. This caused us to mistakenly consume the event as an update instead of a delete.
Instead, we gate on the decoded row's IsDelete.
Fixes: #169778
Release note: none